Refactors path expansion for CLI inputs #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
commented
Jun 23, 2022
Comment on lines
+536
to
+537
| expect(filtered).toContain('2 files analyzed'); | ||
| expect(unfiltered).toContain('4 files analyzed'); |
There was a problem hiding this comment.
This applies to all of the tests that were changed, but the new path expansion logic fixes an issue whereby Checkup was inadvertently including files that should have been excluded. This optimization has had the knock on effect of changing the test output.
scalvert
commented
Jun 23, 2022
| @@ -1,4 +1,4 @@ | |||
| import * as chalk from 'chalk'; | |||
| import chalk from 'chalk'; | |||
There was a problem hiding this comment.
This import was incorrect, and somehow slipped through the ESM conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates file path expansion logic to simplify and correctly observe path exclusions. Fixes a long standing bug with Checkup incorrectly including
dotpaths/directories.