Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtag page doesn't show any posts or the "Follow" option when using GoToSocial #294

Closed
filipesmedeiros opened this issue Nov 1, 2023 · 7 comments
Labels
bug Something isn't working gotosocial

Comments

@filipesmedeiros
Copy link
Sponsor

filipesmedeiros commented Nov 1, 2023

Describe the bug
In my (personal) instance, the hashtag page seems to have two bugs. At https://mastodon.social/@cheeaun/111336065434816529, Chee asked me to report them here:

  1. The "Follow" option in the top right menu doesn't exist (not even disabled). There is a picture attached to show this. See below why this is not a bug! :)
  2. The page can't load the posts with the tag.
  • Which site: phanpy.social
  • Which instance: social.filipesm.eu
  • Which fedi software: GoToSocial

To Reproduce
Steps to reproduce the behavior:

  1. Run a GTS server
  2. Connect to it using https://phanpy.social
  3. Search for a hashtag (e.g. #DoughnutEconomics)
  4. Go to the hashtag page and see the bug

Expected behavior
The "Follow" button exists and posts show up.

Screenshots

Desktop (please complete the following information):

  • OS: MacOS 14.2 Ventura
  • Browser: Vivaldi
  • Version: 6.2

Additional context
I believe that bug number 2 (posts not showing up) is not a bug of Phanpy, but it's just the way GTS works: I have no access to other server's posts if I'm not federating with them, and there isn't backfilling of old posts also.

While researching for this report, I noticed that the above is not true. It might actually be because the request has no authentication, and so we get a 401 back. Picture below.

Screenshot 2023-11-01 at 17 34 22
@filipesmedeiros
Copy link
Sponsor Author

Indeed it seems to be that, because for some reason, if I click a hashtag on my home page, it takes me to a correct page where I have the posts there (still no "Follow" button though). And that request is indeed authenticated with an "Authorization" header.

@filipesmedeiros
Copy link
Sponsor Author

filipesmedeiros commented Nov 1, 2023

Apparently, according to this file, we only display the "Follow" button if the tags request is successful, and GTS doesn't implement it for some reason. What do you think we could do?

EDIT: Oh GTS doesn't implement any tag endpoint, so I guess that's settled... not a bug, that part!

@cheeaun
Copy link
Owner

cheeaun commented Nov 2, 2023

@filipesmedeiros perhaps would be great if this is reported to GTS 🤔 From their roadmap, seems that they've implemented hashtag federation since July and marked as done. Not really sure if it includes following/unfollowing besides just viewing.

You're right regarding the tags request, it's used to know if user is following the tag or not. And… via same endpoint, POST /api/v1/tags/:id/follow (doc) is needed to follow the hashtag.

@filipesmedeiros
Copy link
Sponsor Author

@cheeaun I've reported it and it's on the backlog! superseriousbusiness/gotosocial#2326 (comment) They have implemented tag timelines but not the Tags endpoints :)

But the other issue with fetching the timeline is still there, correct?

@cheeaun cheeaun added bug Something isn't working gotosocial labels Nov 2, 2023
@cheeaun
Copy link
Owner

cheeaun commented Nov 2, 2023

@filipesmedeiros this is a little difficult for me to test without an account 😬 Few things to check:

  • CORS headers?
  • Strict origin issues? But other non-hashtag-page requests works right? 🤔
  • Really weird that Authorization header is gone. Other requests have them?

Thanks! 🙇‍♂️

@filipesmedeiros
Copy link
Sponsor Author

@cheeaun I will debug this tomorrow :)

@filipesmedeiros
Copy link
Sponsor Author

@cheeaun I ran this locally and it's actually fixed in dev so... I'm gonna maybe wait for you to merge it into main and then we can close this? Or maybe close it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gotosocial
Projects
None yet
Development

No branches or pull requests

2 participants