Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Hashtag federation (in/out), hashtag client API endpoints #2032

Merged
merged 21 commits into from Jul 31, 2023

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jul 27, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements the following:

  1. Federate hashtags in and and out of GoToSocial correctly.
  2. Client API to view hashtag timeline.
  3. Client API to search for hashtags.
  4. Serve stub page at web timeline endpoint (pending discussion about what to actually show at these endpoints).
  5. Document hashtag usage in the user guide, and add federation docs for hashtags.

closes #2019
closes #1822
closes #967

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc self-requested a review July 29, 2023 12:31
@NyaaaWhatsUpDoc
Copy link
Member

finished reviewing this now. looks really great!! once the comments have been addressed, jokey ones aside :p, this should be ready to go!

@tsmethurst tsmethurst merged commit 2796a2e into main Jul 31, 2023
3 checks passed
@tsmethurst tsmethurst deleted the hashtaggery branch July 31, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants