Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification settings reset after closing the settings panel #317

Open
slrgt opened this issue Nov 12, 2023 · 5 comments
Open

Notification settings reset after closing the settings panel #317

slrgt opened this issue Nov 12, 2023 · 5 comments

Comments

@slrgt
Copy link

slrgt commented Nov 12, 2023

Describe the bug
Whenever I set what notifications I want to receive once I close the settings section and re open it the settings appear reset although they're actually set and working

To Reproduce
Steps to reproduce the behavior:
Go to settings, allow notifications, close settings, open settings

Expected behavior
Its expected the setting would stay how they are set 😅

Screenshots
Here's how I set them
image

Then here's how it looks when I go back into the settings
image

Smartphone (please complete the following information):

  • Device: iPhone 10S
  • OS: iOS 17.1.1
  • Browser: Safari PWA
  • Version: in screenshot
@cheeaun
Copy link
Owner

cheeaun commented Nov 12, 2023

May I know what's the instance you're on?

@slrgt
Copy link
Author

slrgt commented Nov 12, 2023 via email

@rwmpelstilzchen
Copy link

rwmpelstilzchen commented Jan 11, 2024

Here too, on https://hed.im (Mastodon v4.2.3; vanilla AFAIK). I run Phanpy locally (npm run dev), if it makes any difference.

@rwmpelstilzchen
Copy link

I run Phanpy locally (npm run dev), if it makes any difference.

Well, it does seem to make a difference (or is it something else?): push notifications don’t work (and their settings are not saved) when I run Phanpy on my machine, but they do work (and their settings are saved) when I use phanpy.social.

BTW on src/pages/settings.jsx there is a typo: allowNofitications should be allowNotifications. This is too small to make a pull request…

@rwmpelstilzchen
Copy link

I installed it again (both the ‘easy way’ and the ‘custom-build way’, independently) and it works now. Curiously, now it works also on my previous installation, on which it didn’t work previously. I don’t really understand what has changed, and so far I cannot reproduce the problem. I’d suspect something has changed in the local storage in the browser (which is shared by local Phanpy installations) or in npm after npm install (I’m not a JavaScript developer; I don’t know if this makes sense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants