Remote media: avoid never-ending loops if it won't work #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeaun
reviewed
Dec 11, 2023
rakoo
force-pushed
the
fix-remote-media
branch
from
3273700
to
71454d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've sent a PDF as an attachment to a Status, and phanpy tries to load it, but inside an![]()
tag because that's the "default type". That fails.
In case of error, the code tries to change the url but it turns out to be exactly the same, so it tries again, and fails, and tries again, ad vitam eternam as fast as possible. This burns my CPU and even makes some calls to the same origin fail; the only recourse is to fresh-reload the app.
Non-image types don't seem to have this issue because there's no "retry with another url"
This little change makes sure we don't retry if it failed