Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't highlight mention when it's prepended by a dot #356

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

rakoo
Copy link
Contributor

@rakoo rakoo commented Dec 12, 2023

There is/was a convention that prepending a dot (.) before the @ makes the target user not mentioned. This is useful when you're using DMs for example and you want to talk about a third-party but don't want the third-party to get the message: putting the dot before doesn't send it to them.

@rakoo
Copy link
Contributor Author

rakoo commented Dec 12, 2023

This is probably the shortest PR I'll make in my life.

@cheeaun cheeaun added the bug Something isn't working label Dec 13, 2023
@cheeaun cheeaun merged commit aefbfd5 into cheeaun:main Dec 13, 2023
2 checks passed
@filipesmedeiros
Copy link
Sponsor

@rakoo do you know if this is documented anywhere? I feel like it should. I agree with the feature! But don't know if it should be shipped without any UI tip/feedback about it.

@rakoo
Copy link
Contributor Author

rakoo commented Dec 15, 2023

I totally agree with you but haven't seen any doc anywhere and that's absolutely lacking. Maybe it even works like that for Mastodon because of a bug that might be "fixed" later on haha

@filipesmedeiros
Copy link
Sponsor

filipesmedeiros commented Dec 15, 2023

What do you think @cheeaun? Would a UI tip be welcome?

@cheeaun
Copy link
Owner

cheeaun commented Dec 16, 2023

@rakoo @filipesmedeiros I'm not aware of such convention. I've just tried this on one of my test accounts, turns out the mention prepended by a dot works (it gets converted into a mention by Mastodon), so I might need to revert this change 😅 I'm not sure if this differs in non-Mastodon servers.

The only similar convention I know (from old Twitter days) is that prepending dot in beginning of a post e.g.:

.@someone test

…will show posts in all your followers' timelines. Without the dot, it'll only show on your own timeline and @someone's timeline.

@filipesmedeiros
Copy link
Sponsor

I think it's fairly easy to cover the use case of the issue, @rakoo. Just search for the username, but then delete the initial "@". So have "name@server.com". That won't mention, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants