Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json #1

Merged
merged 2 commits into from Jul 15, 2016
Merged

manifest.json #1

merged 2 commits into from Jul 15, 2016

Conversation

limhenry
Copy link
Contributor

TODO: service worker for "Add to Homescreen" banner and offline.

Note: Icon designed by me.

@cheeaun
Copy link
Owner

cheeaun commented Jul 15, 2016

Would be cool if got a screenshot of how it looks like on a phone (Nexus?)

@limhenry
Copy link
Contributor Author

Screenshot: https://goo.gl/photos/M978D1Avk3pXnjFL6

Video:
https://www.youtube.com/watch?v=A66vZ2nAJrU

First Part:

Second Part:

  • Repokemon with manifest.json (built with polymer)

note: i have no idea why some images are not showing

@cheeaun
Copy link
Owner

cheeaun commented Jul 15, 2016

note: i have no idea why some images are not showing

you mean it doesn't show after adding the manifest or before?

@limhenry
Copy link
Contributor Author

No. That's your website. It's not on localhost.

*btw, I think you should serve the image using HTTPS

@cheeaun
Copy link
Owner

cheeaun commented Jul 15, 2016

Hmm already https now, is it still not loading? @limhenry

For me, all images load but slow because connection limits in the browser 😏

"sizes": "512x512",
"type": "image/png"
}],
"start_url": "/",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm does this go to root? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😭

@cheeaun
Copy link
Owner

cheeaun commented Jul 15, 2016

Would be cool if you can commit the SVG version also. I'll credit you in README, or you could include yourself in the README :P

@limhenry
Copy link
Contributor Author

sure thing. i will make a pr later

@limhenry
Copy link
Contributor Author

@cheeaun done.

updated the start_url and added a super nice pokeball svg file. 😆

@cheeaun cheeaun merged commit 0d5121c into cheeaun:master Jul 15, 2016
@limhenry
Copy link
Contributor Author

sh*t. i forgot to credit myself...

@cheeaun
Copy link
Owner

cheeaun commented Jul 15, 2016

@limhenry can do another PR :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants