fix(manipulation): Have text turn passed values to strings (#2047)

cheeriojs · Aug 14, 2021 · 3d3ed11 · 3d3ed11
1 parent a8b9d13
commit 3d3ed11
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/api/manipulation.spec.ts b/src/api/manipulation.spec.ts
@@ -1901,6 +1901,11 @@ describe('$(...)', () => {
       expect(text).toBe('M&M');
     });
 
+    it('should turn passed values to strings', () => {
+      $('.apple').text(1 as any);
+      expect($('.apple')[0].childNodes[0]).toHaveProperty('data', '1');
+    });
+
     it('( undefined ) : should act as an accessor', () => {
       const $div = $('<div>test</div>');
       expect(typeof $div.text(undefined as any)).toBe('string');

diff --git a/src/api/manipulation.ts b/src/api/manipulation.ts
@@ -1004,7 +1004,7 @@ export function text<T extends Node>(
       child.next = child.prev = child.parent = null;
     });
 
-    const textNode = new Text(str);
+    const textNode = new Text(`${str}`);
 
     updateDOM(textNode, el);
   });