make test safer and more meaningful

cheeriojs · Jan 5, 2021 · 906ca89 · 906ca89
1 parent 89b9271
commit 906ca89
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/test/api/attributes.js b/test/api/attributes.js
@@ -370,8 +370,11 @@ describe('$(...)', function () {
         balls: 'giandor',
       });
       // Adding as string.
-      var b = $('.linth').data('snack', 'chocoletti').data(4, 'chocoletti');
+      var b = $('.linth').data('snack', 'chocoletti');
 
+      expect(function () {
+        a.data(4, 'throw');
+      }).not.toThrow();
       expect(a.data('balls')).toStrictEqual('giandor');
       expect(b.data('snack')).toStrictEqual('chocoletti');
     });

diff --git a/test/cheerio.js b/test/cheerio.js
@@ -392,11 +392,15 @@ describe('cheerio', function () {
     });
 
     it('cloneDom : should be able clone single Elements', function () {
+      var main = cheerio('<p>Cheerio</p>');
       var result = [];
-      utils.domEach(cheerio('<p>A</p><p>B</p>'), function (i, el) {
+      utils.domEach(main, function (i, el) {
         result = result.concat(utils.cloneDom(el));
       });
-      expect(result).toHaveLength(2);
+      expect(result).toHaveLength(1);
+      expect(result[0]).not.toBe(main[0]);
+      expect(main[0].children.length).toBe(result[0].children.length);
+      expect(cheerio(result).text()).toBe(main.text());
     });
 
     it('isHtml function test', function () {