fix(prop): Update attribute value when setting prop (#1579)

Fixes #883 Fixes #927 Fixes #1364
cheeriojs · Dec 22, 2020 · db3fce7 · db3fce7
1 parent c58258f
commit db3fce7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/api/attributes.js b/lib/api/attributes.js
@@ -120,7 +120,11 @@ var getProp = function (el, name) {
 };
 
 var setProp = function (el, name, value) {
-  el[name] = rboolean.test(name) ? !!value : value;
+  if (name in el) {
+    el[name] = value;
+  } else {
+    setAttr(el, name, rboolean.test(name) ? (value ? '' : null) : value);
+  }
 };
 
 /**

diff --git a/test/api/attributes.js b/test/api/attributes.js
@@ -172,6 +172,17 @@ describe('$(...)', function () {
       expect(checkbox.prop('checked')).to.equal(true);
     });
 
+    it('(key, value) : should update attribute', function () {
+      expect(checkbox.prop('checked')).to.equal(true);
+      expect(checkbox.attr('checked')).to.equal('checked');
+      checkbox.prop('checked', false);
+      expect(checkbox.prop('checked')).to.equal(false);
+      expect(checkbox.attr('checked')).to.equal(undefined);
+      checkbox.prop('checked', true);
+      expect(checkbox.prop('checked')).to.equal(true);
+      expect(checkbox.attr('checked')).to.equal('checked');
+    });
+
     it('(map) : object map should set multiple props', function () {
       checkbox.prop({
         id: 'check',