Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for .map method is actually calling .each method #1705

Closed
Pustur opened this issue Jan 31, 2021 · 2 comments · Fixed by #1711
Closed

Test for .map method is actually calling .each method #1705

Pustur opened this issue Jan 31, 2021 · 2 comments · Fixed by #1711

Comments

@Pustur
Copy link
Contributor

Pustur commented Jan 31, 2021

Hello,

I was looking at some test files and I found this line that I think is wrong:

cheerio/test/api/traversing.js

Line 706 in 9b28b49

$fruits.each(function () {

It's in the tests for the .map method but has been changed to .each in 21de2c5

Not sure why it's been changed, but it should be .map being tested here right?

I can open a PR if requested.
@5saviahv
Copy link
Contributor

5saviahv commented Feb 1, 2021

haha, nice - I think it should be map there.

@5saviahv
Copy link
Contributor

5saviahv commented Feb 1, 2021

You are always welcome to create PR.

@Pustur Pustur mentioned this issue Feb 1, 2021
Merged
@fb55 fb55 closed this as completed in #1711 Feb 2, 2021
fb55 pushed a commit that referenced this issue Feb 2, 2021
@Pustur
test: .map test was actually calling .each (#1705) (#1711)
456fbe5 
The added return is to prevent linter errors due to rule `array-callback-return`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong method used in .map tests
2 participants
@Pustur @5saviahv