Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] ignoreWhitespace set to true rather than false? #22

Closed
siddMahen opened this issue Dec 28, 2011 · 4 comments
Closed

[Discussion] ignoreWhitespace set to true rather than false? #22

siddMahen opened this issue Dec 28, 2011 · 4 comments

Comments

@siddMahen
Copy link

I don't particularly see any benefit to not having this option set. Is there any reason this wasn't set already?

@matthewmueller
Copy link
Member

Hmmm... I was left it in so that rendering was as close to the original as possible. I think if we were to ignore it, we'd need to provide an option to run the output through an HTML tidy.

@siddMahen
Copy link
Author

I think we should ignore white spaces as they create unnecessary overhead when filtering text nodes, traversing etc, and implement a tidy output option like you suggested.

@siddMahen
Copy link
Author

Also, I'm not sure if this is consistent with jQuery/intended behavior but with this option on, text nodes are often returned by next() and prev() methods, rather than the next element.

@siddMahen
Copy link
Author

See #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants