Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to parsing with ignoreWhitespace set #27

Merged
merged 1 commit into from
Jan 23, 2012
Merged

Conversation

siddMahen
Copy link

Also removed some files which were never being used, and some extra whitespace floating around.

All tests pass. Just wanted to run this by @matthewmueller instead of committing it directly.

* Also removed some extra whitespace floating around.
@matthewmueller
Copy link
Member

Hi Sidd,

Thanks for your efforts. I'll take a look at this over the weekend.

Do you have a HTML tidy in mind? I think it's important that what comes out of cheerio looks similar (or better) than what goes in (unless otherwise specified).

@matthewmueller matthewmueller merged commit bd00f7e into master Jan 23, 2012
@matthewmueller
Copy link
Member

Works perfectly, thanks!

Also, most of the commit diffs were garbed in whitespace swaps. Do you know how we can keep this cleaner in the future?

@siddMahen
Copy link
Author

I use a vim plugin called vim-trailing-whitespace, which is why there were lots of whitespace swaps, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants