Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded, maybe a bug in cheerio > css-select > domutils #991

Closed
maslow opened this issue Mar 13, 2017 · 3 comments

Comments

@maslow
Copy link

maslow commented Mar 13, 2017

cheerio depends on css-select, which depends on domutils:

RangeError: Maximum call stack size exceeded at tag (.../node_modules/css-select/lib/general.js:21:11) at findAll (.../node_modules/domutils/lib/querying.js:87:6) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27) at findAll (.../node_modules/domutils/lib/querying.js:90:27)

See also :
fb55/domutils#19

@chrboe
Copy link

chrboe commented Mar 13, 2017

Yes, this is a bug in domutils. There's a PR that fixes the issue, as a workaround you can just use the PR creator's fork instead of the original module.

@jugglinmike
Copy link
Member

Looks like this issue is being tracked elsewhere.

@amit777
Copy link

amit777 commented May 30, 2017

hi, sorry to comment on closed ticket, but I see the bug in domutils has been fixed in 1.6.0+, however cheerio still installs 1.5.1. Any plans on bumping up the domutils dependency? I'm not sure if it has a major impact or not.

Edit: sorry, my mistake. It looks like domutils is not directly included into cheerio. Need to find the dependency.

holatuwol added a commit to holatuwol/liferay-intellij that referenced this issue Mar 10, 2018
holatuwol added a commit to holatuwol/liferay-intellij that referenced this issue Mar 10, 2018
holatuwol added a commit to holatuwol/liferay-intellij that referenced this issue Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants