Fix #1253 (stale data on .prev() after replaceWith()) #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed the error I described in #1253. I also modified two test cases to demonstrate the fix.
The problem was that in
uniqueSplice(), the variablenextwas calculated wrongly:nextpointed atspliceIdx, which actually containted the original node to be replaced. When it came to updating references in the linked list (line 104), the reference in the replaced element was changed. But the reference in the following element was not updated so it still pointed to the replaced element.prevreference in the element following the newly inserted element(s) is updated.