Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Add a "bench" alias script #1629

Merged
merged 1 commit into from Jan 4, 2021
Merged

package.json: Add a "bench" alias script #1629

merged 1 commit into from Jan 4, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 2, 2021

No description provided.

@fb55
Copy link
Member

fb55 commented Jan 2, 2021

I'm not a super big fan of having aliases in the package.json. Should we just rename the original script?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 2, 2021

Your call, but alias help because they work in more cases. Feel free to close the PR, it's just I kept running npm run bench. This should allow both cases to work.

@fb55 fb55 merged commit bb6cb38 into cheeriojs:main Jan 4, 2021
@fb55
Copy link
Member

fb55 commented Jan 4, 2021

Decided to merge this, as we don't have insane amounts of scripts at the moment.

@fb55
Copy link
Member

fb55 commented Jan 4, 2021

Thanks @XhmikosR!

@XhmikosR XhmikosR deleted the patch-1 branch January 5, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants