Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Jest's toBe true/false matcher. #1639

Merged
merged 1 commit into from Jan 4, 2021
Merged

Prefer Jest's toBe true/false matcher. #1639

merged 1 commit into from Jan 4, 2021

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 3, 2021

Also, remove some trailing spaces from descriptions.

Might be worth adding https://github.com/jest-community/eslint-plugin-jest later :)

@XhmikosR
Prefer Jest's toBe true/false matcher.
a122e22 
Also, remove some trailing spaces from descriptions.
@5saviahv
Copy link
Contributor

5saviahv commented Jan 3, 2021

Interesting toBe(true) vs toBeTruthy() vs toBeTrue()

@fb55 fb55 merged commit 4859684 into cheeriojs:main Jan 4, 2021
@fb55
Copy link
Member

fb55 commented Jan 4, 2021

Nice one 🙂

Might be worth adding https://github.com/jest-community/eslint-plugin-jest later :)

Good call, looking into it!

@XhmikosR XhmikosR deleted the jest branch January 4, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @5saviahv @fb55