Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unwrap function #1651

Merged
merged 4 commits into from Jan 5, 2021
Merged

Added unwrap function #1651

merged 4 commits into from Jan 5, 2021

Conversation

5saviahv
Copy link
Contributor

@5saviahv 5saviahv commented Jan 4, 2021

Should solve #850

fb55
fb55 reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@fb55 fb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Two minor issues, otherwise this should be good to go.

lib/api/manipulation.js Outdated Show resolved Hide resolved
lib/api/manipulation.js Outdated Show resolved Hide resolved
lib/api/manipulation.js Show resolved Hide resolved
@5saviahv @fb55
Update unwrap parameter
e0aa9f8 
Co-authored-by: Felix Böhm <me@feedic.com>
@fb55 fb55 merged commit 2037d83 into cheeriojs:main Jan 5, 2021
@fb55
Copy link
Member

fb55 commented Jan 5, 2021

Awesome, thanks a lot!

@5saviahv 5saviahv deleted the unwrap branch January 5, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fb55 fb55 fb55 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@5saviahv @fb55