Export all interfaces in declaration file

[dominik-korsa]

fixes #1540, fixes #1649

Note: I don't know what I'm doing, but this fix seems to be working for my case

In these examples, the code compiles and the console.log output Hello as expected

import cheerio from 'cheerio';

const $: cheerio.Root = cheerio.load('<div>Hello</div>');
console.log($('div').text());

import cheerio, { Root } from 'cheerio';

const $: Root = cheerio.load('<div>Hello</div>');
console.log($('div').text());

import type { Root } from 'cheerio';
import cheerio from 'cheerio';

const $: Root = cheerio.load('<div>Hello</div>');
console.log($('div').text());

Tested with this tsconfig: https://gist.github.com/dominik-korsa/5888e24c196e50fa673154e030cf11ce

I wasn't able to test CommonJS (require()) syntax

[5saviahv]

Good catch, it seems it is not good practice to use same variable name twice 🤔

declare namespace cheerio {...}
...
declare const cheerio: cheerio.CheerioAPI;
export = cheerio;

[rondonjon]

@5saviahv

Good catch, it seems it is not good practice to use same variable name twice

It seems to be quite common, see Advanced Combinations for some examples

[rondonjon]

The proposed solution also solves #1692 for me.

Since your solution is more compatible, I have closed PR #1695.

[keyiis]

@dominik-korsa Are you installed @types/cheerio?if use cheerio own types,still not work.

[dominik-korsa]

As far as I know @types/cheerio is only for versions 0.x, as versions 1.x will include bundled declarations.

[keyiis]

@dominik-korsa i used cheerio version

"cheerio": "^1.0.0-rc.3"

i already solved #1696

[ejose19]

Would be great if this is merged, as exposing interfaces makes it easier to work than ReturnType<typeof cheerio.load> or similar.

[fb55]

Thanks @dominik-korsa!

[CzBiX]

This fix doesn't works for me.
Please export all interfaces like this: https://github.com/axios/axios/blob/master/index.d.ts

Also the import cheerio from 'cheerio' doesn't work for ES6, see https://stackoverflow.com/a/56348146

[jpujol880807]

This fix doesn't works for me.
Please export all interfaces like this: https://github.com/axios/axios/blob/master/index.d.ts

Also the import cheerio from 'cheerio' doesn't work for ES6, see https://stackoverflow.com/a/56348146

like @keyiis said downgrade your version of cheerio to "cheerio": "^1.0.0-rc.3" and install @types/cheerio. Those type definitions work with that version but no with the 1.0.0-rc.5 then u can do import cheerio from 'cheerio' and use cheerio.Root and so on