root will be overwritten #1706
Closed
root will be overwritten #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
reviewed
Feb 4, 2021
|
@5saviahv This is yet another great PR. I have one question about this, otherwise it should have been pretty much good to go. |
|
My doubts were mainly if context is provided and is object - do I have to add some more testing there ? |
Co-authored-by: Felix Böhm <me@feedic.com>
fb55
reviewed
May 14, 2021
| @@ -53,7 +53,7 @@ var Cheerio = (module.exports = function (selector, context, root, options) { | |||
|
|
|||
| if (root) { | |||
| if (typeof root === 'string') root = parse(root, this.options, false); | |||
| this._root = Cheerio.call(this, root); | |||
| this._root = new Cheerio(root); | |||
There was a problem hiding this comment.
Finally figured out what's wrong here: This should be new this.constructor(root). Incorporating this in a different PR.
fb55
added a commit
that referenced
this pull request
May 14, 2021
Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root will be overwritten if you parse new html content.
lets say you
turns out since
el._root&elare same instance. if you adddivinto dom you effectively overwritingroot. Now when you plan make query against that old root you get empty results since new emptydivwont have old content.