Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nesting level of some deeply nested tests decreased #1734

Merged
merged 2 commits into from Feb 18, 2021
Merged

nesting level of some deeply nested tests decreased #1734

merged 2 commits into from Feb 18, 2021

Conversation

5saviahv
Copy link
Contributor

.add function had some 3rd and 4th level nested tests.

  • looking from output those indentations are rather subtle and no longer easily readable, I moved them to 2nd level and added argument descriptions used in tests.
  • Also those deeply nested tests aren't very easy to follow in code.
  • no actual change in tests, just formatting.

fb55
fb55 reviewed Feb 14, 2021
View reviewed changes
test/api/traversing.js Outdated Show resolved Hide resolved
@fb55
Copy link
Member

fb55 commented Feb 14, 2021

Nice PR! One comment seems to have been forgotten, otherwise this should be good to go.

@5saviahv @fb55
Update test/api/traversing.js
7d1a871 
Co-authored-by: Felix Böhm <me@feedic.com>
@fb55 fb55 merged commit 9743030 into cheeriojs:main Feb 18, 2021
@fb55
Copy link
Member

fb55 commented Feb 18, 2021

Thanks for following up!

@5saviahv 5saviahv deleted the update-test branch February 25, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fb55 fb55 fb55 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@5saviahv @fb55