refactor(options): Revamp option handling #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htmlparser2 options have been moved out of the root options for Cheerio, making it more obvious which options will take effect. This currently only affects the TypeScript type.
Users that want to use htmlparser2 should use the `xml` option:
```js
const $ = cheerio.load('<html>', { xml: {
withStartIndices: true
}})
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2744. I'm not quite happy yet, but am out of ideas of how to improve the situation without breakages in JS code.
htmlparser2 options have been moved out of the root options for Cheerio, making it more obvious which options will take effect. This only affects the TypeScript type.
Users that want to use htmlparser2 should use the
xmloption:Just as before, users are still able to force htmlparser2 using a combination of
xmlandxmlMode: