Remove unused variable references #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
| @@ -49,7 +49,7 @@ var setAttr = function(el, name, value) { | |||
| } | |||
| }; | |||
|
|
|||
| var attr = exports.attr = function(name, value) { | |||
There was a problem hiding this comment.
I'd like to remove all of these. Even those that are referenced are unnecessary, as we can reference exports.<name> instead. Thoughts?
|
Very nice! |
Prefer accessing these methods via the global `module` namespace for clarity.
|
@davidchambers The only excuse for aliasing exported methods is to avoid the overhead of dereferencing. Really though, if we were concerned with performance at that level, Cheerio would be a native module. I've implemented your suggestion. |
|
I find this line of reasoning compelling, @jugglinmike. I'll give @matthewmueller and @fb55 a chance to chime in before we merge this pull request. |
|
haha coveralls is pretty sweet. I'm +1 to this idea. I've kind of been liking... Cheerio.prototype.after = require('./api/manipulation/after');Lately... but that would be a bigger change. |
|
That's three thumbs up. Merging. :) |
davidchambers
added a commit
that referenced
this pull request
Jul 1, 2014
Remove unused variable references
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.