Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against node v0.12 --> v4.2 #773

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Test against node v0.12 --> v4.2 #773

merged 1 commit into from
Oct 28, 2015

Conversation

JaKXz
Copy link
Contributor

@JaKXz JaKXz commented Oct 23, 2015

No description provided.

@fb55
Copy link
Member

fb55 commented Oct 24, 2015

Thanks, definitely a welcome patch :)

This requires a jsdom update as well, even though AFAIK it is only required for benchmarking. It should probably be updated and moved to optionalDependencies.

0.10 and 0.11 (including the allow_failures entry) can be removed, and latest should be added.

@JaKXz Could you update your patch to include these changes?

@JaKXz
Copy link
Contributor Author

JaKXz commented Oct 24, 2015

@fb55 done :)

EDIT: according to nvm-sh/nvm#731, we'll probably want to use the conventional stable alias. Would you like me to add unstable as well and maybe even add it to allow_failures?

@fb55
Copy link
Member

fb55 commented Oct 25, 2015

Allowing failures for unstable is a good idea. Also, it should be
possible to use containers by passing sudo: false in the .travis.yml.

@JaKXz
Copy link
Contributor Author

JaKXz commented Oct 27, 2015

@fb55 I think we're good now - would you like me to squash these commits? otherwise have fun and thanks for a great library :)

@fb55
Copy link
Member

fb55 commented Oct 27, 2015

@JaKXz Squashing the commits would be great, thanks a lot already :)

- Test latest node and remove 0.10 and 0.11 and allow for failing tests against the latest unstable release, just for curiousity.

- Update jsdom to its latest version to support benchmarking on node 4+.
@JaKXz
Copy link
Contributor Author

JaKXz commented Oct 28, 2015

@fb55 all done :)

fb55 added a commit that referenced this pull request Oct 28, 2015
Test against node v0.12 --> v4.2
@fb55 fb55 merged commit 6c73b7a into cheeriojs:master Oct 28, 2015
@fb55
Copy link
Member

fb55 commented Oct 28, 2015

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants