Allow Booleans as permissible return values from YML #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cheezy let me know what you think. I can also add a couple cucumber tests for this if you'd like. |
| @@ -57,18 +64,28 @@ Feature: Functionality of the fig_newton gem | |||
| Given I have read the configuration file | |||
| When I ask for a value that does not exist named "does_not_exist" that has a default value "the default value" | |||
| Then I should see "the default value" | |||
|
|
|||
|
|
|||
| Scenario: Requesting data that does not exist but has a default value of true should return the default value of true | |||
There was a problem hiding this comment.
This scenario and the one below it are failing in local tests -- looks like my proposed change does not work for booleans specified as defaults. Not sure if this is even necessary, but looking into it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a local.yml that looks like this:
This will allow us to call:
Without this change we get the following: