Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achieving True Cucumber 2.0 Support #44

Open
azohra opened this issue Oct 26, 2015 · 3 comments
Open

Achieving True Cucumber 2.0 Support #44

azohra opened this issue Oct 26, 2015 · 3 comments

Comments

@azohra
Copy link

azohra commented Oct 26, 2015

Hi Folks,

I noticed @cheezy pushed a commit updating the require statements to core/ast, and I think it is time we pushed and updated Pretty Face to be fully Cucumber 2.0 compatible.

I have found the following roadblocks thus far:

1. ensure_io now only takes a single argument
Offending Code: html.rb-46

@io = ensure_io(path_or_io, 'html')

2. Cucumber::Ast API calls are deprecated
Offending Code: html.rb & report.rb

Cucumber::Ast::Table::Cells
Cucumber::Ast::ScenarioOutline
Cucumber::Ast::Background
Cucumber::Ast::OutlineTable::ExampleRow
Cucumber::Ast::Scenario

Some of these calls can simply be updated to Cucumber::Core::Ast, but others have been removed/renamed in the Cucumber code-base and need to be rebuilt.

I am working on a set of local updates and believe I am close to solving the above roadblocks, I will report back with my results and hopefully we can get this translated to a pull request soon.

Best,
J

@cheezy
Copy link
Owner

cheezy commented Nov 29, 2015

What is checked into github right now is a work in progress. There are still several issues that need to be resolved. I am “slowly” working on it but haven’t found an adequate amount of time to push it forward lately due to travel and work. Hopefully I can find some more time this week.

On Nov 25, 2015, at 11:46 AM, Justin Commu notifications@github.com wrote:

I posted a bounty for this in hopes it might inspire someone :)
I am struggling to get table data read correctly in my local efforts to achieve Cucumber 2 support.

https://www.bountysource.com/issues/27712038-achieving-true-cucumber-2-0-support https://www.bountysource.com/issues/27712038-achieving-true-cucumber-2-0-support

Reply to this email directly or view it on GitHub #44 (comment).

@mupcakes
Copy link

the wait on this has been killing meee

@azohra
Copy link
Author

azohra commented May 14, 2016

@mupcakes, check out Reportbuilder & Allure while you wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants