Remove deprecated examples using Array of Hashes #358
Conversation
Due to #328 we must update the README.md to remove references to the Array of Hashes syntax. ```ruby default['audit']['profiles'] = [] default['audit']['profiles'].push( name: 'example', compliance: 'admin/example' ) ``` becomes ```ruby default['audit']['profiles'] = {} default['audit']['profiles']['example'] = { compliance: 'admin/example' } ``` Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
| @@ -85,6 +85,8 @@ | |||
|
|
|||
| # Chef Inspec Compliance profiles to be used for scan of node | |||
| # See README.md for details | |||
| # TODO: Make this `{}` in next major version | |||
| # See: https://github.com/chef-cookbooks/audit/pull/328 | |||
| default['audit']['profiles'] = [] | |||
There was a problem hiding this comment.
I am not sure but removing examples will not resolve the main issue of hash of hashes #328 as we still having default as array.
There was a problem hiding this comment.
Correct, I was not aware Hash of Hashes was broken. We are going to leave the current docs for now, then when we get Hash of Hashes working we will make sure we include setting the parent to {} in all examples.
There was a problem hiding this comment.
we'll also need to update the Automate 2 examples for when this is released as they use the .push method as well
There was a problem hiding this comment.
@teknofire can you add any links to #359
Want to make sure we track them in all the places.
There was a problem hiding this comment.
There was a problem hiding this comment.
|
Merged as part of #386 Thanks! |
Due to #328 we must update the README.md to remove references to the Array of Hashes syntax.
becomes