[fog][DEPRECATION] Passing the public key as the 2nd arg is deprecated, please pass a hash of attributes.

[martinb3]

When using the fog_key_pair resource with fog:Rackspace, and the key is being created for the first time, I'm getting the following warning (note the log output is also missing a path, it just ends in "key at..."):

[fog][DEPRECATION] Passing the public key as the 2nd arg is deprecated, please pass a hash of attributes.

    - create example_id_rsa on fog:Rackspace: from local key at 

The resource in question is:

fog_key_pair 'example_id_rsa'

This appears to be coming from fog/lib/fog/rackspace/requests/compute_v2/create_keypair.rb:

        def create_keypair(key_name, attributes = nil)
          key_data = { 'name' => key_name }

          if attributes.is_a?(String)
            Fog::Logger.deprecation "Passing the public key as the 2nd arg is deprecated, please pass a hash of attributes."
            key_data.merge!("public_key" => attributes)
          end

          key_data.merge!(attributes) if attributes.is_a?(Hash)

This is being called from chef-provisioning-fog at lib/chef/provider/fog_key_pair.rb on line 106:

            when 'Rackspace'
              compute.create_keypair(new_resource.name, Cheffish::KeyFormatter.encode(desired_key, :format => :openssh))

What's interesting is that on the Joyent impl. on line 102, the hash key is added:

compute.create_key(name: new_resource.name, key: Cheffish::KeyFormatter.encode(desired_key, :format => :openssh))

Maybe there's a reason for doing it differently?