Fix issue where package provider override isn't working when specifying a package_source #18
Conversation
…e provider is used. also get to 100% test coverage
|
Is this still required, given your last comment chef/chef#3487? |
|
Hey @jtimberman - Lamont chimed in with a much nicer implementation using I updated this PR to use I guess ultimately it comes down to how you feel about promoting the |
| return Chef::Provider::Package::Rpm if node['platform_family'] == 'rhel' | ||
| def local_package_resource | ||
| return :dpkg_package if node['platform_family'] == 'debian' | ||
| return :rpm_package if node['platform_family'] == 'rhel' |
There was a problem hiding this comment.
should probably return :package here by default, or else raise if you don't want to try to guess that.
|
The declare_resource bits LGTM 👍 |
| @@ -1,5 +1,5 @@ | |||
| name 'chef-server-ingredient' | |||
| version '0.3.2' | |||
| version '0.3.3' | |||
There was a problem hiding this comment.
Let's not increment versions in PR's 🍰
There was a problem hiding this comment.
sorry about that! fixed.
This reverts commit 0dca70a.
Fix issue where package provider override isn't working when specifying a package_source
Per the comments in chef/chef#3487 - passing a provider to the package resource is unreliable and causing problems for our customers that need to specify a
package_sourceThis PR also adds tests for the
test::localrecipe and gets up to 100% test coverage 😄cc: @jtimberman