[KNIFE-334] Add an option to create DNS 'A' records in Rackspace Cloud DNS when a node is created #51
Conversation
…ore bootstrapping
…g is a good thing.
@chrissnell Can you rebase this as well? |
This has now been rebased. I did a little code cleanup on my DNS patches, as well. I've tested it and I think it's ready to commit. I hope that this PR is useful for folks. Here's how I'm testing it: % knife rackspace server create -N demo- This would create a dns record for node-SECONDSSINCEEPOCH.snellytest.com. Obviously, you would substitute your domain for 'snellytest.com' and substitute your own run list. The domain (zone) must be set up in your account beforehand, either within the control panel or through the API. |
Hey @chrissnell @krames is there an internal JIRA ticket for this on tickets.opscode.com? If not, could you please create one, link to this PR, link this PR to the ticket, and mark the ticket as "Fix Provided" in JIRA? |
@chrissnell Can you answer @sethvargo question? Thanks! |
@sethvargo JIRA ticket has been created. I didn't see any way to mark it as "fix provided". Maybe that's something you can do on your end? |
Thanks @chrissnell, I've updated the ticket and PR. You don't have a "Fix Provided" button because you're not in the JIRA dev group. Only people who have a signed CLA get that magic button 😄. Because you work for Rackspace, you're covered by Rackspace's CCLA, but I'm not sure how we get you JIRA access - I've asked internally. For now, I've marked the JIRA ticket as Fix Provided and added a similar comment there. In the future, you'll have a button to mark as "Fix Provided". |
@chrissnell okay, I've got the scoop. It looks like there's an internal contact at Rackspace (most likely someone in legal) who manages the CLA relationship with Opscode. You'll need to ping him/her and ask to be added to the list. /cc @krames |
Thanks @sethvargo. I believe that @krames took care of our internal legal ticket here a few weeks ago. |
@chrissnell totally possible that it's just waiting on the space robots or some rabbitmq 😄 |
Is this ever going to get merged in? |
@tlalexan we are waiting for the CLA to be processed |
@sethvargo I sent you an email about this. |
I replied :) |
@chrissnell Can you update the README.rdoc to include instructions on how to use this switch? |
@@ -94,6 +94,26 @@ def connection | |||
end | |||
end | |||
|
|||
def dnsconnection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fog has started to refer to these as services rather than connections. Can we rename this method to dns_service
to keep with fog's convention? I think it will be easier for future developers.
@chrissnell I made some suggestions to make the code flow a little better. Let me know if you have any questions. |
Pinging @chrissnell -- is this still something we want to merge? Just update the KNIFE ticket when the PR is updated and set to fix provided -- thanks. |
Hi @adamedx Yes, I'd like to merge it eventually but it needs some clean-up and more documentation. Due to a rookie git mistake on my part, this PR also contains code changes that were pushed as part of PR #42 . I could rebase everything and remove everything that was part of #42 but I think it might be better to just start with a fresh PR. What do you guys think? @krames etc |
@chrissnell I think you are safe to just rebase against master. |
I spoke to @chrissnell about this on Friday. He says that he no longer needs this functionality and does not have the capacity to work on it. Unless there are any objections, I would like to just close this pull request without merging. |
I could personally use this functionality. However I am unable to spend the time to contribute the code necessary, I'll leave it up to others to decide if they want to put the work in on this. |
@jvervlied Sounds like their is still a need for this. I will keep it open. Thanks for the response! |
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. Non-GitHub Verified CommittersThere are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute. GitHub Users Who Are Not Authorized To ContributeThe following GitHub users do not appear to have signed a CLA: |
Given that it's been 3 years, and no further interest or contributions have occurred, I'm going to close this one. If you need this functionality, I'd recommend doing it in the converge using the rackspacecloud cookbook on the new node. |
http://tickets.opscode.com/browse/KNIFE-334
This PR adds an option "--rackspace-add-dns-record" that will create an A record within Cloud DNS when a node is created. This option takes a DNS zone name as a parameter and create an A record of . that points to the public IP of the new node. This PR is a continuation of the work in the previous PR I submitted:
#42
This new PR depends on the work in PR #42, which adds more intelligent determination of the correct public IP in RackConnect environments.