Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic versioning? #7

Closed
agperson opened this issue Mar 30, 2015 · 4 comments
Closed

Use semantic versioning? #7

agperson opened this issue Mar 30, 2015 · 4 comments

Comments

@agperson
Copy link

Since 0.5.0 is not backwards compatible as it (intentionally) breaks Chef 11 functionality, time to bump to 1.0.0?

@reset
Copy link
Contributor

reset commented Mar 30, 2015

@agperson bumping from 0.4.x to 0.5.x is the correct change according to SemVer 2.0.0.

4. Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
8. Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes are introduced to the public API. It MAY include minor and patch level changes. Patch and minor version MUST be reset to 0 when major version is incremented.

The key here being X > 0 in section 8. For projects which do not have a major version greater than 0, I would use the pessimistic operator to lock to a minor version. ~> 0.4.0.

@reset reset closed this as completed Mar 30, 2015
@agperson
Copy link
Author

Okie dokie, thanks. In accordance with the SemVer FAQ that means this is not production ready and shouldn't be used by other cookbooks with version >= 1.0.0. Disappointing.

@reset
Copy link
Contributor

reset commented Mar 30, 2015

@agperson I actually don't think the doc says that at all. It does make mention about an API you want to remain consistent and respecting backwards compatibility. This software isn't 1.0 because of the exact issues that the 0.5.x release is attempting to fix - compile time race wars. This will be bumped to 1.0 once I have had enough success testing the 0.5.x release in my production environment.

@agperson
Copy link
Author

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants