Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test helpers #52

Merged
merged 2 commits into from Mar 24, 2013
Merged

new test helpers #52

merged 2 commits into from Mar 24, 2013

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Mar 23, 2013

A collection of what we have been reusing in our projects, enjoy :)

@grosser
Copy link
Contributor Author

grosser commented Mar 23, 2013

just saw the tests, I'll add some :)

@calavera
Copy link
Contributor

nice 👍

@calavera
Copy link
Contributor

@grosser please, can you be more descriptive in your commit messages? they help me collect the changelog between versions without checking every commit.

Thanks for adding this!

@grosser
Copy link
Contributor Author

grosser commented Mar 23, 2013

Ok, everything cleaned and tested.
Also notices that you had an open load-path -> tests loaded libraries from the installed gem, fixed that :)

@grosser
Copy link
Contributor Author

grosser commented Mar 23, 2013

the ci runner kills all colors for minitest, so got rid of the pointless pride requirement, not sure if that's fixable...

@calavera
Copy link
Contributor

this is really cool @grosser ❤️ Would you mind to delete that Gemfile? I don't think it's necessary, thanks!!

@grosser
Copy link
Contributor Author

grosser commented Mar 24, 2013

ups, everything is already in the gemspec / gemfile_chef_11,
I just moved it so things work by default and users do not have to BUNDLE_GEMFILE=foo

calavera pushed a commit that referenced this pull request Mar 24, 2013
@calavera calavera merged commit 8611d29 into chef-boneyard:master Mar 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants