modified platform_family logic #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- amazon has platform_versions like "2013.03" which would have fallen through into the RHEL5-like case statement and been broken. there is probably a rhel-5-like-vs-rhel-6-like breakpoint somewhere in the platform_versions here, but i don't know we really care that badly about old amazon platforms. - i switched the case statement around to match rhel-5 tighter and fall through into rhel-6-like behavior, on the assumption that it is a lot more likely that rhel-7 will behave like rhel-6 and rhel-5 is certain to be wrong. - fedora is not in the "rhel" family so added that explicitly and again made it rhel-6-like and older rhel5-like fedora is not supported
|
|
so this doesn't merge any more. runit cookbook got moved to being pulled from the community via berkshelf and via indirection from the https://github.com/opscode-cookbooks/enterprise-chef-common cookbook. It looks like its using >1.0.0 so should be pulling in latest, so CHEF-3838 is probably a bug in upstream community runit cookbook then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
through into the RHEL5-like case statement and been broken. there is
probably a rhel-5-like-vs-rhel-6-like breakpoint somewhere in the
platform_versions here, but i don't know we really care that badly
about old amazon platforms.
fall through into rhel-6-like behavior, on the assumption that it is
a lot more likely that rhel-7 will behave like rhel-6 and rhel-5 is
certain to be wrong.
again made it rhel-6-like and older rhel5-like fedora is not supported