Corrected subserver & added chdev/chfs #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 38 : the regex cannot match lines with some extra commands & args for the inetd entry Line 39 : obviously, a correct line starting with a # is disabled, so (# == # ) => true which should be false. Line 91 : added the "-r inetd" to the command line
Strangly it appears that with required set to true, the recipe always claims that the attribute is non present even with the correct value
=> Changed the way we load the current resource => corrected the way we update a already existing subserver => corrected the way we create a new subserver => fixe bug when your subserver has already been renamed => added accessor exists & already_exists_with_new_name
=> chdev : Change aix devices attributes => chfs : increase/decrease aix Filesystem size => user : work with aix users => group : work with aix groups
removed user & group has they don't belong here Updated README.md to relfect changes.
| attr_accessor :exists | ||
|
|
||
|
|
||
| # TODO: |
There was a problem hiding this comment.
Are there actually TODOs left?
This version handles the following cases : `:enable` : + if the service name does not exists, create it with the supplied parameters + if some parameter is missing, raise an error + if the service exists, update it + if some parameters are not compatible each others, raise an error (sunrpc_udp // tcp) + it the service is not enabled, enable it.
|
@vfoucault are you still working on this? |
|
@vfoucault chfs has to be included in a lvm/fs provider. We are working on it. chdev has been commited in another pull request. Can I close the pull request ? Or are you still working on it ? |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request compile the previously created ones (and closed).
Fixed the
subserverprovider which wasn't working. It has some defects loading theinetd.confresources and commands to create/update were wrong.Corrected some issues also in the resource.
Added the following providers :
chdev: udpate AIX devices attributeschfs: change AIX filesystem size (+/-)updated the
README.mdto include some details about the providers.