Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow json-file output location to be configured #327

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Allow json-file output location to be configured #327

merged 3 commits into from
Sep 19, 2018

Conversation

nvwls
Copy link
Contributor

@nvwls nvwls commented Aug 7, 2018 •
edited
Loading

Signed-off-by: Joe Nuspl nuspl@nvwls.com

Description

Add node['audit']['json_file']['location'] to specify the json-file output location

Issues Resolved

#286

Check List

@nvwls
Allow json-file output location to be configured
c503ede 
Signed-off-by: Joe Nuspl <nuspl@nvwls.com>
@nvwls nvwls requested a review from a team August 7, 2018 19:26
alexpop
alexpop approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Joe for the contribution. Can you please rebase the branch so we can merge and release this change with the 7.1.0 release?

@alexpop
Copy link
Contributor

alexpop commented Sep 19, 2018

Thank you Joe for the contribution!
I'm merging it now and then proceed with releasing a new version that includes the change.

@alexpop alexpop merged commit 62e8d07 into chef-boneyard:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpop alexpop alexpop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvwls @alexpop @chris-rock