-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated examples #83
Updated examples #83
Conversation
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. Non-GitHub Verified CommittersThere are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute. |
@@ -14,6 +14,12 @@ export COMPLIANCE_API='https://compliance.test/api' | |||
export COMPLIANCE_REFRESHTOKEN='40/YUP...mA=='' | |||
``` | |||
|
|||
For Windows devs, you can set these environment variables in PowerShell (recommended over user/system variables): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 that is a great addition
@jwmathe Great work. Lets simplify the cookbooks a little bit, since they are here for demo purposes only.
|
I apologize for all the comments, I know that those files are all auto-generated. Let me know if you have no time, I can help on that. |
I am looking forward to add those examples to this cookbook, since they are really helpful! Thanks again for doing all the work to add those! |
@jwmathe Please do not forget to sign the CLA |
@chris-rock Made the suggested changes to the two example cookbooks. Signed CLA as of 8/16 |
Cheers for this PR Jeff 👍 |
@alexpop commits squashed. |
@jwmathe awesome, somehow your github user is not assigned to the CLA? Looks like you are not using the you github email for the commit |
@jwmathe Anything I can help with? |
…le, updated kitchen examples readme Fix rubocop syntax flags Updated README to include chef automate ingest article URL Changed quotes for data_collectors in visibility_ingest.rb Removed non-essential files from example cookbooks. Removed comments related to copyright. Added include_recipe chef_client_visibility to default recipe. Removed comments in metadata files. Removed comments in Berksfile. Renamed example cookbooks and simplifed structure Modified include_recipe statement in visibility_converge::default to 'visibility_converge::chef_client_visibility' Added # encoding: utf-8 to all ruby files in example cookbooks
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
Thanks @jwmathe |
Description
These changes update example with some additional examples for a wrapper cookbook, which depends on an ingest-visibility cookbook (which also has an example), and updated the kitchen examples.
Issues Resolved
Check List
…le, updated kitchen examples readme