New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples #83

Merged
merged 1 commit into from Sep 14, 2016

Conversation

Projects
None yet
4 participants
@jwmathe
Contributor

jwmathe commented Aug 16, 2016

Description

These changes update example with some additional examples for a wrapper cookbook, which depends on an ingest-visibility cookbook (which also has an example), and updated the kitchen examples.

Issues Resolved

Check List

…le, updated kitchen examples readme

@chef-supermarket

This comment has been minimized.

chef-supermarket commented Aug 16, 2016

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

@@ -14,6 +14,12 @@ export COMPLIANCE_API='https://compliance.test/api'
export COMPLIANCE_REFRESHTOKEN='40/YUP...mA==''
```
For Windows devs, you can set these environment variables in PowerShell (recommended over user/system variables):

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

👍 that is a great addition

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/.gitignore Outdated
@@ -0,0 +1,16 @@
.vagrant

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

let not add a .gitignore, since its not the project root and only an example

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/.rubocop.yml Outdated
@@ -0,0 +1,7 @@
AllCops:

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

no need for rubocop in our example

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/Berksfile Outdated
@@ -0,0 +1,6 @@
# You can add your internal Chef Supermarket as the first source if you host
# your own cookbooks
source 'https://yourinternal.supermarket.com'

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

we should remove:

+# You can add your internal Chef Supermarket as the first source if you host
 +# your own cookbooks
 +source 'https://yourinternal.supermarket.com'
@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/LICENSE Outdated
@@ -0,0 +1,3 @@
Copyright 2016, All Rights Reserved.

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

Our cookbook has Apache 2 only, lets remove that here, since we have a LICENSE in our project root

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/chefignore Outdated
@@ -0,0 +1,102 @@
# Put files/directories that should be ignored in this file when uploading

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

this file is not needed here

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/metadata.rb Outdated
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '0.1.0'
# Put in the URL to your internal git server, or github if it is hosted there.

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

lets remove the comments here

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/recipes/default.rb Outdated
@@ -0,0 +1,5 @@
#

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

lets call chef_client_visibility.rb from default

@chris-rock

View changes

examples/visibility_ingest_cookbook/config_winchefclient/spec/unit/recipes/default_spec.rb Outdated
# Cookbook Name:: config_winchefclient
# Spec:: default
#
# Copyright 2016, All Rights Reserved.

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

Can you remove all proprietary copyright header? This conflicts with our cookbook license

@chris-rock

View changes

...ity_ingest_cookbook/config_winchefclient/test/integration/default/serverspec/default_spec.rb Outdated
@@ -0,0 +1,9 @@
require 'spec_helper'

This comment has been minimized.

@chris-rock

chris-rock Aug 23, 2016

Collaborator

Lets remove the sample integration tests, we do not need those here

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 23, 2016

@jwmathe Great work. Lets simplify the cookbooks a little bit, since they are here for demo purposes only.

  • remove all non-essential files eg. .gitignore, .rubocop.yml, LICENSE, test/integration, CHANGELOG.md
  • simplify the folder structure: eg. visibility_converge, and wrapper_audit
@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 23, 2016

I apologize for all the comments, I know that those files are all auto-generated. Let me know if you have no time, I can help on that.

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 23, 2016

I am looking forward to add those examples to this cookbook, since they are really helpful! Thanks again for doing all the work to add those!

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 23, 2016

@jwmathe Please do not forget to sign the CLA

@jwmathe

This comment has been minimized.

Contributor

jwmathe commented Aug 29, 2016

@chris-rock Made the suggested changes to the two example cookbooks. Signed CLA as of 8/16

@alexpop

This comment has been minimized.

Collaborator

alexpop commented Sep 8, 2016

Cheers for this PR Jeff 👍
Could you please squash the commits before we merge this?

@jwmathe

This comment has been minimized.

Contributor

jwmathe commented Sep 8, 2016

@alexpop commits squashed.

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Sep 8, 2016

@jwmathe awesome, somehow your github user is not assigned to the CLA? Looks like you are not using the you github email for the commit

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Sep 13, 2016

@jwmathe Anything I can help with?

@jwmathe

This comment has been minimized.

Contributor

jwmathe commented Sep 13, 2016

image

Still unsure why the CLA is not recognizing my account. The account I use to log in to Github is the same account I use to push changes to github from command line. That Github account shows it is linked to my Chef Supermarket account, which shows it is authorized to contribute.

Added a wrapper cookbook example, an ingest-visibility cookbook examp…
…le, updated kitchen examples readme

Fix rubocop syntax flags

Updated README to include chef automate ingest article URL

Changed quotes for data_collectors in visibility_ingest.rb

Removed non-essential files from example cookbooks.  Removed comments related to copyright.  Added  include_recipe chef_client_visibility to default recipe.  Removed comments in metadata files.  Removed comments in Berksfile.

Renamed example cookbooks and simplifed structure

Modified include_recipe statement in visibility_converge::default to 'visibility_converge::chef_client_visibility'

Added # encoding: utf-8 to all ruby files in example cookbooks
@chef-supermarket

This comment has been minimized.

chef-supermarket commented Sep 14, 2016

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Sep 14, 2016

Thanks @jwmathe

@chris-rock chris-rock merged commit b0bb1b6 into chef-cookbooks:master Sep 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment