Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digs into pageable response for snapshot lists #128

Merged
merged 2 commits into from Jun 28, 2015
Merged

digs into pageable response for snapshot lists #128

merged 2 commits into from Jun 28, 2015

Conversation

sonnysideup
Copy link
Contributor

change required by aws-sdk v2 gem

change required by aws-sdk v2 gem
because attempting to attach a snapshot in a "pending" state is silly
@sonnysideup
Copy link
Contributor Author

Also added a check for the snapshot state because attempting to create an EBS volume from a snapshot in a "pending" state results in an error.

@scalp42
Copy link
Contributor

scalp42 commented Apr 17, 2015

LGTM

@sonnysideup
Copy link
Contributor Author

How do we get this merged into master?

@scalp42
Copy link
Contributor

scalp42 commented Apr 28, 2015

Need to wait for a guy from Opscode to look at it @drywheat 🔮

@miketheman miketheman added ebs and removed ebs labels Jun 13, 2015
@miketheman miketheman added the ebs label Jun 28, 2015
@miketheman miketheman added this to the 2.7.2 milestone Jun 28, 2015
miketheman added a commit that referenced this pull request Jun 28, 2015
digs into pageable response for snapshot lists
@miketheman miketheman merged commit afa451d into sous-chefs:master Jun 28, 2015
@miketheman
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants