Fixes #35, implement fqdn_resolves? method #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes this issue: - chef-cookbooks/chef-server#105
jtimberman
pushed a commit
to chef-cookbooks/chef-server
that referenced
this pull request
Aug 27, 2015
The api_fqdn_resolves? method should use the new method that is in the chef-ingredient cookbook. It is implemented in that cookbook here: - chef-cookbooks/chef-ingredient@14a54e9 Reference: - chef-cookbooks/chef-ingredient#36 - https://github.com/chef-cookbooks/chef-ingredient/issue/35
|
@chef-cookbooks/engineering-services |
| require 'resolv' | ||
| Resolv.getaddress(fqdn) | ||
| return true | ||
| rescue |
There was a problem hiding this comment.
We should rescue the specific ResolvError exception here.
|
👍 |
1 similar comment
|
👍 |
jtimberman
added a commit
that referenced
this pull request
Aug 31, 2015
…lper Fixes #35, implement fqdn_resolves? method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes this issue: