Use PRODUCT_MATRIX from mixlib-install #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with ingredient_config and omnibus_service
|
Per Slack, we need I'm 👍 on this. 🚀 🍰 🚢 |
sersut
force-pushed
the
sersut/product-matrix
branch
from
5584373
to
000aebc
Compare
sersut
force-pushed
the
sersut/product-matrix
branch
from
b5a4bd0
to
86b8df6
Compare
sersut
pushed a commit
that referenced
this pull request
Dec 3, 2015
Use PRODUCT_MATRIX from mixlib-install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes PRODUCT_MATRIX and associated helpers and makes chef-ingredient use that functionality from mixlib-install. There is also some minor cleanup in helpers and improved documentation + naming.
Also note that it is rebased on top of #71
/cc: @chef-cookbooks/engineering-services