New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PRODUCT_MATRIX from mixlib-install #73

Merged
merged 4 commits into from Dec 3, 2015

Conversation

Projects
None yet
2 participants
@sersut
Contributor

sersut commented Dec 3, 2015

This PR removes PRODUCT_MATRIX and associated helpers and makes chef-ingredient use that functionality from mixlib-install. There is also some minor cleanup in helpers and improved documentation + naming.

Also note that it is rebased on top of #71

/cc: @chef-cookbooks/engineering-services

jtimberman and others added some commits Dec 3, 2015

@jtimberman

This comment has been minimized.

Show comment
Hide comment
@jtimberman

jtimberman Dec 3, 2015

Member

Per Slack, we need mixlib-install gem updated so we can get the prerelease gem w/ the product matrix changes.

I'm 👍 on this. 🚀 🍰 🚢

Member

jtimberman commented Dec 3, 2015

Per Slack, we need mixlib-install gem updated so we can get the prerelease gem w/ the product matrix changes.

I'm 👍 on this. 🚀 🍰 🚢

sersut pushed a commit that referenced this pull request Dec 3, 2015

Serdar Sutay
Merge pull request #73 from chef-cookbooks/sersut/product-matrix
Use PRODUCT_MATRIX from mixlib-install

@sersut sersut merged commit b9a95c9 into master Dec 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sersut sersut deleted the sersut/product-matrix branch Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment