Allow the specification of a constrained version #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the option of specifying a constrained version using the standard constraint syntax [1]. [1] https://docs.chef.io/cookbook_versions.html Resolves chef-cookbooks#7 Signed-off-by: Andy Wagner <andy@andywagner.ca>
Rarian
force-pushed
the
version_constraints
branch
from
3f08e41
to
555ce00
Compare
|
@tas50 Let me know if this needs any more work. |
|
mixlib-install already supports versions like "12" which means "12.x.x" aka "~> 12.0" |
|
also generally if mixlib-install doesn't support it, this cookbook shouldn't support it, and feature enhancements should go into mixlib-install. this cookbook should not fork the behavior of mixlib-install and should remain as thin a wrapper as is possible. |
|
I've never been able to have anything but an infinite loop when specifying a version like "12". Anyway, feel free to close this and the corresponding issue if you like. This was just something I picked to work on randomly at the hackathon. |
|
its possible that functionality simply needs to be fixed. |
|
yeah closing in favor of #17 |
|
infinite loop fixed in #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the option of specifying a constrained version using the standard constraint syntax.
Issues Resolved
#7
Check List