Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new options format #28

Closed
sekrett opened this issue Apr 6, 2016 · 4 comments
Closed

Use new options format #28

sekrett opened this issue Apr 6, 2016 · 4 comments
Labels
Stale This is marked as stale and will be closed shortly

Comments

@sekrett
Copy link
Contributor

sekrett commented Apr 6, 2016

  1. Instead of:
    WITH_APACHE=true and WITHOUT_APACHE=true
    it should be:
    OPTIONS_FILE_SET+=APACHE and OPTIONS_FILE_UNSET+=APACHE

  2. Cookbook should merge old options and convert correctly.

  3. The head should be added:

    # Options for php56-5.6.19
_OPTIONS_READ=php56-5.6.19
_FILE_COMPLETE_OPTIONS_LIST=CLI CGI FPM EMBED PHPDBG DEBUG DTRACE IPV6 MAILHEAD LINKTHR ZTS

I will try to implement this.
@sekrett
Copy link
Contributor Author

sekrett commented Apr 11, 2016

Implemented in v0.7.0. Not converting old options, not needed, because FreeBSD also ignores old WITH/WITHOUT.

@martinisoft
Copy link

I commented on the pull request @sekrett as it looks like we didn't get around to the code review and it has a few conflicts along with needing to comply with the DCO. Once that has been updated we'll take a look and thank you for sending the contribution. 👍

sekrett added a commit to sekrett/freebsd that referenced this issue Mar 9, 2017
@sekrett
Use new options file format (sous-chefs#28),
5aab803 
include directory name (sous-chefs#27),
add port provider (sous-chefs#18)
Signed-off-by: Alexander Zubkov <info@zubkov.info>
sekrett added a commit to sekrett/freebsd that referenced this issue Mar 9, 2017
@sekrett
Use new options file format (sous-chefs#28),
97a23bc 
include directory name (sous-chefs#27),
add port provider (sous-chefs#18)
Signed-off-by: Alexander Zubkov <info@zubkov.info>
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale This is marked as stale and will be closed shortly label Jan 8, 2021
@github-actions
Copy link

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale This is marked as stale and will be closed shortly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martinisoft @sekrett @cheeseplus @tas50