Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #103 and remove options from svc start #104

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@jonlives
Copy link
Collaborator

commented Jun 19, 2018

Signed-off-by: Jon Cowie jonlives@gmail.com

Description

This PR attempts to fix issue #103. Under Hab 0.56.0 and greater, the hab svc start and stop commands do not expect to receive some supervisor options like --channel etc which were previously supported.

This change removes unsupported options from the :start and :stop actions. It further ensures that the service is loaded correctly using hab svc load (by way of the action_load method) before attempting to start it.

This PR also upgrades the installed version of Hab to 0.57.0, just released today. This was done to fix habitat-sh/habitat#5178, which was hit under 0.56.1.

Issues Resolved

#103

Check List

Fix #103
This commit removes options from the :start and :stop actions which are no longer supported by Hab > 0.56.0. It also upgrades the installed supervisor to the new 0.57.0 release, and fixes a minor change in the supervisor output used to detect running services.

Signed-off-by: Jon Cowie <jonlives@gmail.com>

@jonlives jonlives force-pushed the jonlives:master branch from 647826d to 3e6237f Jun 19, 2018

@jtimberman

This comment has been minimized.

Copy link
Member

commented Jun 19, 2018

🥇

@jtimberman jtimberman merged commit 737c109 into chef-cookbooks:master Jun 19, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

chef-ci pushed a commit that referenced this pull request Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.