Fix #103 and remove options from svc start #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes options from the :start and :stop actions which are no longer supported by Hab > 0.56.0. It also upgrades the installed supervisor to the new 0.57.0 release, and fixes a minor change in the supervisor output used to detect running services. Signed-off-by: Jon Cowie <jonlives@gmail.com>
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jon Cowie jonlives@gmail.com
Description
This PR attempts to fix issue #103. Under Hab 0.56.0 and greater, the hab svc start and stop commands do not expect to receive some supervisor options like --channel etc which were previously supported.
This change removes unsupported options from the :start and :stop actions. It further ensures that the service is loaded correctly using hab svc load (by way of the action_load method) before attempting to start it.
This PR also upgrades the installed version of Hab to 0.57.0, just released today. This was done to fix habitat-sh/habitat#5178, which was hit under 0.56.1.
Issues Resolved
#103
Check List