Updated cookbook for habitat API post 0.56.0 #115

wduncanfraser · 2018-07-30T21:16:14Z

Description

Added hab_user_toml resource for templating user.toml
Added auth token support for private organizations
- auth_token is passed ont he command line for a package install
- HAB_AUTH_TOKEN is templated into the service definition for the supervisor if specified
Remove invalid Habitat API options that no longer apply since Habitat 0.56.0
Added listen_ctl option for hab_sup resource
Added remote_sup option for communication with non-default supervisor
Locked supervisor version to hab version
Set launcher version to make sure it is updated appropriately for hab sup
Set the supervisor service to restart if hab-sup or hab-launcher package resources change
Removed validation of channel name, as channels can be arbitrarily created on bldr
Expanded testing to cover changes
Updated readme

Issues Resolved

This closes #106
This closes #102

Check List

All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
New functionality includes testing.
New functionality has been documented in the README if applicable
All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Added hab_user_toml resource Added qol features for private builder and private organizations Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

st-h · 2018-08-01T13:04:56Z

I tried if this PR would solve my issues regarding installing private packages, however it still fails when trying to install a private package. I think you missed to fix one spot, where it currently is tried to determine the availability of the package via an http request. You can find my PR to fix this here.

Otherwise I would love to see something like this get merged, however it probably would have been easier to follow along the changes if it would have been multiple PRs. I just hope you know how to get PRs merged within this repo. I was trying to get some feedback from the maintainers for a few weeks on the way the unsupported hab token should be implemented, but did not have any luck at all (I mostly got ignored when following official recommendations). I think we could do properties like you did, use the env var (as this is what hab usually does), or use a cookbook attribute (which would be neat as well, as you only have to specify it once)

However, last time someone needed to get a PR merged, they pinged @tas50 . Let's see how that goes this time...

wduncanfraser · 2018-08-01T16:46:39Z

@st-h I'll re-validate the stand alone package installation on my end and get that fix pulled in 👍 . Did you also attempt via service load, to where the supervisor itself handles the installation? That I validated thoroughly across the three service providers on our end as we use that workflow internally.

I'll see if I can poke anyone on the habitat/chef side and may break this up into multiple PRs if the maintainers would prefer. I was largely just porting work over from updating the cookbook for internal use and wanted to start the conversation.

Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

wduncanfraser · 2018-08-01T17:16:14Z

@st-h Validated the issue you were seeing. Pulled in your fix from #113 but had it use the auth_token property on the package resource. Validate the fix is working 👍 Thank you for catching that.

st-h · 2018-08-01T17:17:56Z

@wduncanfraser Yeah, iirc the service resource only seems to need the environment set on the init/upstart etc scripts. Otherwise setting the env var works well, except for the http request that bypasses the hab client, that causes the install resource to fail. That actually took me quite some time to figure out, as I wasn't expecting a wild http request to suddenly appear at all.

Let's hope we will get some feedback soon. I am running a patched version myself, but did not submit everything yet, I was hoping to get a response from the maintainers myself before doing so.

st-h · 2018-08-01T17:19:07Z

btw, this PR should fix #114 as well

st-h · 2018-08-01T17:23:18Z

I think we could also get rid of that http request, if we could use the hab pkg search api. However, I was unable to find any spec for the search terms. Did ask on the habitat slack, but no avail. Did not have time to go through the source or ask on the hab forum though.

wduncanfraser · 2018-08-01T17:31:23Z

Yeah, it would probably be good to depend on the hab search API in the future, as then it's less that has to be maintained in the cookbook itself. Though I will leave that task for a separate PR :)

st-h · 2018-08-01T18:09:05Z

@wduncanfraser absolutely 💯 I don't know how functional the search api actually currently is though - maybe that's why they used a plain http request in first place.
I just successfully ran a kitchen converge using your recent changes. So, it at least fixes all my initial converge issues with this cookbook. Will deploy this to test soon to see if I can find anything else.

wduncanfraser · 2018-08-08T16:13:17Z

@st-h Just wanted to check in and make sure everything was working for you. Sounds like the primary maintainer for the cookbook is out of the office ATM which is why it has been quite on the PR.

st-h · 2018-08-08T16:22:08Z

@wduncanfraser just was about to comment 😀 I deployed your branch to prod this week as this is the most reliable version of this cookbook I have seen so far. I was having some issues with updating to a new version of a package that was installed via the hab_package resource. The new version did not get picked up on a chef client run. Did not have time to look closer into this though.

who is the primary maintainer?

wduncanfraser · 2018-08-08T20:05:23Z

@st-h That would be @jtimberman to my knowledge.

jonlives · 2018-08-09T10:30:12Z

I'll be taking a look at this PR over the next day or two and hopefully cutting a new release soon :)

jonlives

I've added one request and a comment to this PR.
Since this PR is adding a lot of new things it would be great if it could be split up into a few smaller PRs as mentioned earlier in the conversation, specifically the parts which add / change resources, since it will make it a lot easier to review. If you'd be OK with doing that, my aim is to have this reviewed and a new release cut in the next couple of days - at first blush though, this looks good.

jonlives · 2018-08-09T10:44:47Z

libraries/resource_hab_sup.rb

        end
      end

      action_class do
+        HAB_VERSION = '0.59.0'.freeze


This version pin replicates the pin defined in https://github.com/chef-cookbooks/habitat/blob/master/resources/install.rb#L86. If we're going to be pinning to that version in multiple places, I'd like us to extract that somewhere to be shared between all locations which need to pin.

jonlives · 2018-08-09T10:45:33Z

libraries/provider_hab_package.rb

@@ -116,7 +122,7 @@ def depot_package(name, version = nil)
              name_version = [pkg_name, version].compact.join('/').squeeze('/').chomp('/').sub(%r{^\/}, '')
              url = "#{new_resource.bldr_url.chomp('/')}/v1/depot/channels/#{origin}/#{new_resource.channel}/pkgs/#{name_version}"
              url << '/latest' unless name_version.count('/') >= 2
-              Chef::JSONCompat.parse(http.get(url))
+              Chef::JSONCompat.parse(http.get(url, Authorization: "Bearer #{new_resource.auth_token}"))


What is the behaviour here where no auth_token has been specified?

I'll add a conditional on this.

wduncanfraser · 2018-08-09T16:48:15Z

@jonlives I'll work on getting this split up into smaller PRs today.

jonlives · 2018-08-10T10:19:28Z

Awesome thank you!

jonlives · 2018-08-21T11:39:16Z

@wduncanfraser do you think you'll be able to get around to the smaller PRs? If time is a blocker I can go through the single larger PR.

wduncanfraser · 2018-08-24T15:36:52Z

@jonlives I apologize for the delay, got a little crazy on this end. Working on this now.

wduncanfraser · 2018-08-24T17:07:18Z

@jonlives Opened up new PRs breaking out changes.

jonlives · 2018-09-03T11:56:51Z

Awesome thank you for getting to those, will go through them and try and get a new release cut as soon as I can.

jonlives · 2018-09-04T13:32:18Z

Closing this PR in favour of the new sub-PRs containing the same changes

W. Duncan Fraser added 2 commits July 30, 2018 13:15

Updated cookbook for habitat API post 0.56.0

1593391

Added hab_user_toml resource Added qol features for private builder and private organizations Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

Added user-toml to travis test matrix

09bc05d

Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

Fixed inability of package resource to search a private bldr org

2e2df5d

Signed-off-by: W. Duncan Fraser <wdf@alasconnect.com>

jonlives suggested changes Aug 9, 2018

View reviewed changes

jonlives mentioned this pull request Aug 9, 2018

provide habitat token when bypassing hab client #113

Closed

4 tasks

jonlives closed this Sep 4, 2018

wduncanfraser deleted the private-builder-qol branch January 9, 2019 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated cookbook for habitat API post 0.56.0 #115

Updated cookbook for habitat API post 0.56.0 #115

wduncanfraser commented Jul 30, 2018 •

edited

Loading

st-h commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018 •

edited

Loading

st-h commented Aug 1, 2018

st-h commented Aug 1, 2018

st-h commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018

st-h commented Aug 1, 2018

wduncanfraser commented Aug 8, 2018 •

edited

Loading

st-h commented Aug 8, 2018

wduncanfraser commented Aug 8, 2018

jonlives commented Aug 9, 2018

jonlives left a comment

jonlives Aug 9, 2018

jonlives Aug 9, 2018

wduncanfraser Aug 9, 2018

wduncanfraser commented Aug 9, 2018

jonlives commented Aug 10, 2018

jonlives commented Aug 21, 2018

wduncanfraser commented Aug 24, 2018

wduncanfraser commented Aug 24, 2018

jonlives commented Sep 3, 2018

jonlives commented Sep 4, 2018

Updated cookbook for habitat API post 0.56.0 #115

Updated cookbook for habitat API post 0.56.0 #115

Conversation

wduncanfraser commented Jul 30, 2018 • edited Loading

Description

Issues Resolved

Check List

st-h commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018 • edited Loading

st-h commented Aug 1, 2018

st-h commented Aug 1, 2018

st-h commented Aug 1, 2018

wduncanfraser commented Aug 1, 2018

st-h commented Aug 1, 2018

wduncanfraser commented Aug 8, 2018 • edited Loading

st-h commented Aug 8, 2018

wduncanfraser commented Aug 8, 2018

jonlives commented Aug 9, 2018

jonlives left a comment

Choose a reason for hiding this comment

jonlives Aug 9, 2018

Choose a reason for hiding this comment

jonlives Aug 9, 2018

Choose a reason for hiding this comment

wduncanfraser Aug 9, 2018

Choose a reason for hiding this comment

wduncanfraser commented Aug 9, 2018

jonlives commented Aug 10, 2018

jonlives commented Aug 21, 2018

wduncanfraser commented Aug 24, 2018

wduncanfraser commented Aug 24, 2018

jonlives commented Sep 3, 2018

jonlives commented Sep 4, 2018

wduncanfraser commented Jul 30, 2018 •

edited

Loading

wduncanfraser commented Aug 1, 2018 •

edited

Loading

wduncanfraser commented Aug 8, 2018 •

edited

Loading