Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime types are not deleted #321

Closed
neilfrawley opened this issue Apr 3, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@neilfrawley
Copy link

commented Apr 3, 2017

Cookbook version

iis 5.1.0

Chef-client version

12.19.36

Platform Details

Windows Server 2012 R2

Scenario:

When trying to use the iis_root resource and the delete_mime_maps property the mime types do not get deleted, but the Chef run reports no error.

Steps to Reproduce:

In metadata.rb in a cookbook specify;
depends 'iis', '~> 5.1.0'

In a recipe specify this code;

iis_root 'remove mime types' do
  action :delete
  delete_mime_maps [
    "fileExtension='.rpm',mimeType='audio/x-pn-realaudio-plugin'",
    "fileExtension='.msi',mimeType='application/octet-stream'"
  ]
end

Expected Result:

The 2 mime types get deleted from IIS.

Actual Result:

The mime types do not get deleted from IIS. The Chef run in test kitchen reports as (up to date), yet the mime types are still present.

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2017

Creating inspec tests for this so we can validate the code and fix if necessary. Sorry for the delay in communication

@neilfrawley

This comment has been minimized.

Copy link
Author

commented Apr 3, 2017

Thanks. Let me know if you need anything else from me. Cheers

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2017

We are in the process of re-writing all the resources (moved to doing one at a time)...example: #322 i'll be updating them alphabetically so once we get to iis_root this will be re-written to a custom resource and will have actual tests. any bugs (including this one) will be resolved then.

@EasyAsABC123 EasyAsABC123 added this to the v6.0.0 milestone Apr 6, 2017

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2017

@neilfrawley i think this is because of the section lock, while re-writing the iis_module resource i've run across something similar.

@EasyAsABC123 EasyAsABC123 modified the milestones: v6.0.0, v7 Apr 20, 2017

@EasyAsABC123 EasyAsABC123 self-assigned this May 3, 2017

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2017

I'll add a test for this when i get to the iis_root resource (next on the list)

@neilfrawley

This comment has been minimized.

Copy link
Author

commented May 3, 2017

OK fantastic, thanks

@EasyAsABC123 EasyAsABC123 referenced this issue May 9, 2017

Merged

`iis_root` custom resource #351

4 of 4 tasks complete
@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2017

@neilfrawley resolved in #351 according to the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.