Use resource_for_node() instead of hardcoding User #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably should be done for all other |
|
Paging Dr. @tas50 Also, I filed chef/chef#5412 to have Chef explain itself better in the future. |
With Chef 12.14.89 the `Chef::Resource::User` class isn't "real" and throws `NotImplementedError` (with no message, grrr) and shows up in the output as `user_resource_abstract_base_class`. Instead, `Chef::Resource.resource_for_node(:user, node)` has to be used to get the real user class (e.g. `LinuxUser`) Fixes #513 Signed-off-by: Christian Höltje <docwhat@gerf.org>
|
@iennae is working on a fix using build_resource |
|
@docwhat Thanks for your contribution here, but I'm not going to be pulling this in. As @lamont-granquist mentioned I'm going to be fixing the Chef::Resource::* issues via build_resource as this cookbook has already moved to a 12+ model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Chef 12.14.89 the
Chef::Resource::Userclass isn't "real" andthrows
NotImplementedError(with no message, grrr) and shows upin the output as
user_resource_abstract_base_class.Instead,
Chef::Resource.resource_for_node(:user, node)has to beused to get the real user class (e.g.
LinuxUser)Fixes #513