Add all known keys to the known hosts file #73
Conversation
axos88
force-pushed
the
master
branch
3 times, most recently
from
167c228
to
7311fd0
Compare
attributes/cacher.rb
Outdated
| @@ -0,0 +1,2 @@ | |||
| default['ssh_known_hosts']['cacher']['data_bag'] = 'server_data' | |||
| default['ssh_known_hosts']['cacher']['data_bag_item'] = 'known_hosts' | |||
There was a problem hiding this comment.
splitting up attributes files is pointless, they're all parsed no matter what recipe is in the run list.
There was a problem hiding this comment.
Well from chef's pow, yes, it's pointless, but from the developer's point of view clear separation of concerns be a good thing.
There was a problem hiding this comment.
I'd prefer one file that was organized well, rather than a dozen files with an attribute or two each so I only have one file to open up in an editor.
And splitting things up into different files doesn't address separation of concerns. It just means you have to load more files into the editor and context switch between them.
There was a problem hiding this comment.
Never experienced the problem of switching between files, as I have a file list to the left with sublime.
I will put it back to the default.rb if you have such strong feelings about this.
metadata.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
| license 'Apache 2.0' | |||
| description 'Dyanmically generates /etc/ssh/ssh_known_hosts based on search indexes' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '4.1.0' | |||
| version '4.2.0' | |||
There was a problem hiding this comment.
also please don't bump the version in the metadata, automation typically handles this and it causes merge conflicts
There was a problem hiding this comment.
Sorry, this was not supposed to be part of the PR. We had released a new version internally since the PR was created.
|
Removed the version bump, it was an oversight when submitting the PR. |
…eep old behaviour. Signed-off-by: Akos Vandra <akos@vandra.hu>
Description
Add all known keys (not only one) to the known hosts file (rsa, dsa, ecdsa, etc).