Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #271 making notify work for windows_task #348

Merged
merged 1 commit into from
Mar 9, 2016
Merged

fixes #271 making notify work for windows_task #348

merged 1 commit into from
Mar 9, 2016

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Mar 4, 2016

No description provided.

@smurawski
Copy link
Contributor

rubocop is not so happy :/

@smurawski
Copy link
Contributor

Once rubocop is happy 👍

@mwrock
Copy link
Contributor Author

mwrock commented Mar 8, 2016

cc @chef-cookbooks/windows-cookbook-collaborators @chef-cookbooks/client-windows

@adamedx
Copy link
Contributor

adamedx commented Mar 9, 2016

what was root cause of bug -- not using a consistent name in different contexts?

@mwrock
Copy link
Contributor Author

mwrock commented Mar 9, 2016

the .prepend method on task_name changes the state of the string (should be a prepend! if you ask me but sadly they did not ask) so since that is assigned to the resource_name the resource_name changes and then the notify goes nowhere.

@tyler-ball
Copy link

👍 :shipit:

mwrock added a commit that referenced this pull request Mar 9, 2016
@mwrock
Merge pull request #348 from chef-cookbooks/task
fd83f6c 
fixes #271 making notify work for windows_task
@mwrock mwrock merged commit fd83f6c into master Mar 9, 2016
@mwrock mwrock deleted the task branch March 9, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwrock @smurawski @adamedx @tyler-ball @chef-supermarket