Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dcos_user custom resource #10

Merged
merged 3 commits into from Mar 20, 2018
Merged

Add dcos_user custom resource #10

merged 3 commits into from Mar 20, 2018

Conversation

rbanffy
Copy link
Contributor

@rbanffy rbanffy commented Feb 13, 2018

  • Add a dcos_user custom resource
  • Other small changes

@luisdavim
Copy link

Looks like rubocop and cookstyle are conflicting with each other.

Rubocop says that %w-literals should be delimited by [ and ] and CookStyle is saying %w-literals should be delimited by ( and )....

@jjasghar
Copy link

Can you add this to the README also? I think i know what this means, but It would be nice to have the documentation around it too.

@rbanffy rbanffy force-pushed the master branch 2 times, most recently from e55ddcd to 1fcdaea Compare February 16, 2018 16:04
jjasghar
jjasghar reviewed Feb 16, 2018
View reviewed changes
resources/dcos_user.rb Outdated
# Cookbook Name:: dcos
# Recipe:: default
#
# Copyright 2016, Chef Software, Inc.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright needs to be updated here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The assignment, I assume, is fine.

@rbanffy
Copy link
Contributor Author

rbanffy commented Feb 23, 2018

@jjasghar we on our side think that, after this last commit, we can be happy with the results for a while. Is it good for merging now?

@wolf31o2
Copy link
Collaborator

I'm going to go ahead and merge this to put into 1.2.0 which I am about to release.

wolf31o2
wolf31o2 approved these changes Mar 20, 2018
View reviewed changes
Copy link
Collaborator

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource does essentially the same thing as dcos_add_user.py shipped with DC/OS.

@wolf31o2 wolf31o2 merged commit e3048dd into chef-partners:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjasghar jjasghar jjasghar left review comments

@luisdavim luisdavim luisdavim approved these changes

@wolf31o2 wolf31o2 wolf31o2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rbanffy @luisdavim @jjasghar @wolf31o2