Remove zookeeper Gem requirements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
force-pushed
the
updates-from-testing
branch
from
470bf25
to
e628cfd
Compare
Move the `require 'zookeeper'` blocks inside the resources that use them versus the global scope. Also, support strings instead of just booleans in `dcos_enterprise?` helper. Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>
wolf31o2
force-pushed
the
updates-from-testing
branch
from
e628cfd
to
3ad3b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
require 'zookeeper'blocks inside the resources thatuse them versus the global scope. Also, support strings instead of
just booleans in
dcos_enterprise?helper.Signed-off-by: Chris Gianelloni wolf31o2@gmail.com