Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple versions of DC/OS #8

Merged
merged 2 commits into from Nov 13, 2017
Merged

Support multiple versions of DC/OS #8

merged 2 commits into from Nov 13, 2017

Conversation

wolf31o2
Copy link
Collaborator

@wolf31o2 wolf31o2 commented Sep 4, 2017

NOTE: This is a breaking change!

Introduce support for multiple versions of DC/OS. This is currently
supported from DC/OS 1.8.7 through 1.9.3 and EarlyAccess.

  • Improve IP detection
    • Simplify AWS/GCE selection
    • Always detect address from host, versus static via Ohai
  • Dependency / prerequisite updates
    • Bumped selinux cookbook for newer Chef compatibility
    • Stop and disable rsyslog service
    • Ensure curl, tar, and xz are present
    • Disable IPv6 with sysctl cookbook
    • Allow disabling management of Docker for advanced setups
  • Update Tests
    • Increase resources for Vagrant-based tests
    • Use CentOS 7.3
    • Use loopback for IP detection
  • Miscellaneous updates
    • Move downloads to /usr/src/dcos
    • Support arbitrary configuration values, verus static list
    • Avoid notifies/subscribes for idempotency
    • Use multi package for installs
    • Increase minimum required Chef version to 12.1

Signed-off-by: Chris Gianelloni wolf31o2@gmail.com

@wolf31o2
Copy link
Collaborator Author

wolf31o2 commented Sep 4, 2017

I have readme and more testing updates coming. If you'd rather wait for those, I understand.

@jjasghar
Copy link

jjasghar commented Sep 4, 2017

Nope, more the better. I dedicate some time to verifying this as soon as you're ready for this to be tested.

@wolf31o2
Copy link
Collaborator Author

wolf31o2 commented Sep 5, 2017

I updated the README and rebased. The additional tests I mentioned are InSpec tests, which I will do in another pull request. This is ready for review.

@ghost
Copy link

ghost commented Sep 27, 2017

@jjasghar let me know if there's anything I can do to help with this.

NOTE: This is a breaking change!

Introduce support for multiple versions of DC/OS. This is currently
supported from DC/OS 1.8.7 through 1.10.0 and EarlyAccess.

- Improve IP detection
  - Simplify AWS/GCE selection
  - Public IP detection scripts for AWS/GCE and onprem
  - Always detect address from host, versus static via Ohai
- Dependency / prerequisite updates
  - Bumped selinux cookbook for newer Chef compatibility
  - Stop and disable rsyslog service
  - Ensure curl, tar, and xz are present
  - Allow disabling management of Docker for advanced setups
- Update Tests
  - Increase resources for Vagrant-based tests
  - Use CentOS 7.4 under Vagrant
  - Use loopback for IP detection
  - Remove ServerSpec tests
  - Add InSpec tests
  - Add .kitchen.dokken.yml for Travis CI
- Miscellaneous updates
  - Move downloads to /usr/src/dcos
  - Support arbitrary configuration values, versus static list
    - Support rexray configuration by converting attributes to YAML
  - Avoid notifies/subscribes for idempotency
  - Use multi package for installs
  - Support explicit Docker version selection
  - Increase minimum required Chef version to 12.1

Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>
Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>
@ghost
Copy link

ghost commented Nov 3, 2017

I added DC/OS 1.9.5 and 1.10.1 support. Let me know before merging this, so I can rebase/squash it.

@ghost
Copy link

ghost commented Nov 3, 2017

Also, there's integration tests. They passed.

@jjasghar
Copy link

I'll release this today.

@jjasghar jjasghar merged commit 69ef1b5 into chef-partners:master Nov 13, 2017
@wolf31o2 wolf31o2 deleted the multiple-dcos-versions branch November 13, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants